From 45b0e7cf1a2278ab22d388f1cbc724160101cb8a Mon Sep 17 00:00:00 2001 From: Yassine TIJANI Date: Thu, 6 Jul 2017 15:03:21 +0200 Subject: [PATCH] fixing SIGSEGV when running containers Signed-off-by: Yassine TIJANI moving the deffering of the close after the error checking Signed-off-by: Yassine TIJANI fixing SIGSEGV when running containers Signed-off-by: Yassine TIJANI --- cli/command/container/run.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cli/command/container/run.go b/cli/command/container/run.go index 56f0d0d57b..695a5cf9ae 100644 --- a/cli/command/container/run.go +++ b/cli/command/container/run.go @@ -190,10 +190,11 @@ func runContainer(dockerCli *command.DockerCli, opts *runOptions, copts *contain } close, err := attachContainer(ctx, dockerCli, &errCh, config, createResponse.ID) - defer close() + if err != nil { return err } + defer close() } statusChan := waitExitOrRemoved(ctx, dockerCli, createResponse.ID, copts.autoRemove)