mirror of https://github.com/docker/cli.git
gometalinter: fix configuration
The configuration abused "Exclude" to exclude file-paths by filtering
on the output, however, the `Skip` option was designed for that, whereas
`Exclude` is for matching warnings.
An explicit "Skip" was added for "vendor", because even though the vendor
directory should already be ignored by the linter, in some situations,
it still seemed to warn on issues, so let's explicitly ignore it.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 71e525f74f
)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
parent
08b5f63b0e
commit
d85a3b265c
|
@ -2,12 +2,16 @@
|
||||||
"Vendor": true,
|
"Vendor": true,
|
||||||
"Deadline": "2m",
|
"Deadline": "2m",
|
||||||
"Sort": ["linter", "severity", "path", "line"],
|
"Sort": ["linter", "severity", "path", "line"],
|
||||||
"Exclude": [
|
"Skip": [
|
||||||
"cli/compose/schema/bindata.go",
|
"cli/compose/schema/bindata.go",
|
||||||
"cli/command/stack/kubernetes/api/openapi",
|
"cli/command/stack/kubernetes/api/openapi",
|
||||||
"cli/command/stack/kubernetes/api/client",
|
"cli/command/stack/kubernetes/api/client",
|
||||||
".*generated.*",
|
".*generated.*",
|
||||||
"parameter .* always receives"
|
"vendor"
|
||||||
|
],
|
||||||
|
"Exclude": [
|
||||||
|
"parameter .* always receives",
|
||||||
|
"_esc(Dir|FS|FSString|FSMustString) is unused"
|
||||||
],
|
],
|
||||||
"EnableGC": true,
|
"EnableGC": true,
|
||||||
"Linters": {
|
"Linters": {
|
||||||
|
|
Loading…
Reference in New Issue