From c7d7b50003d23f6828cd5b5c8a6985bff8f123f8 Mon Sep 17 00:00:00 2001 From: Evan Hazlett Date: Tue, 8 Nov 2016 11:34:45 -0500 Subject: [PATCH] more review updates - return err instead of wrap for update secret - add omitempty for data in secret spec Signed-off-by: Evan Hazlett --- command/service/opts.go | 1 - command/service/opts_test.go | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/command/service/opts.go b/command/service/opts.go index 45adb37672..b81998ec09 100644 --- a/command/service/opts.go +++ b/command/service/opts.go @@ -585,7 +585,6 @@ func addServiceFlags(cmd *cobra.Command, opts *serviceOptions) { flags.BoolVar(&opts.healthcheck.noHealthcheck, flagNoHealthcheck, false, "Disable any container-specified HEALTHCHECK") flags.BoolVarP(&opts.tty, flagTTY, "t", false, "Allocate a pseudo-TTY") - flags.StringSliceVar(&opts.secrets, flagSecret, []string{}, "Specify secrets to expose to the service") } const ( diff --git a/command/service/opts_test.go b/command/service/opts_test.go index 85de3ae88a..aa2d999dcf 100644 --- a/command/service/opts_test.go +++ b/command/service/opts_test.go @@ -6,6 +6,7 @@ import ( "time" "github.com/docker/docker/api/types/container" + "github.com/docker/docker/opts" "github.com/docker/docker/pkg/testutil/assert" )