From 0b8f46b061e8c69db1e316015e61d6495da0c391 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 28 Aug 2020 12:35:08 +0200 Subject: [PATCH] Dockerfile: fix dynbinary inside dev container Running `make dynbinary` inside the dev-container failed because gcc was not installed. Adding the `build-base` metapackage, which has gcc, make, g++ and other packages that are needed. Before this change: $ make -f docker.Makefile shell $$ make dynbinary ./scripts/build/dynbinary Building dynamically linked build/docker-linux-amd64 # github.com/docker/cli/cmd/docker /usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: exec: "gcc": executable file not found in $PATH make: *** [Makefile:63: dynbinary] Error 2 With this patch applied $ make -f docker.Makefile shell $$ make dynbinary ./scripts/build/dynbinary Building dynamically linked build/docker-linux-amd64 $$ echo $? 0 Signed-off-by: Sebastiaan van Stijn --- dockerfiles/Dockerfile.dev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dockerfiles/Dockerfile.dev b/dockerfiles/Dockerfile.dev index 2629907069..a131cda9fd 100644 --- a/dockerfiles/Dockerfile.dev +++ b/dockerfiles/Dockerfile.dev @@ -2,7 +2,7 @@ ARG GO_VERSION=1.13.15 FROM golang:${GO_VERSION}-alpine -RUN apk add -U git make bash coreutils ca-certificates curl +RUN apk add --no-cache bash build-base ca-certificates coreutils curl git # v0.1.1 ARG VNDR_SHA=85886e1ac99b8d96590e6e0d9f075dc7a711d132